Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #23977: Allow creating a table with non-existent external location #23994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #23977: Allow creating a table with non-existent external location #23994

wants to merge 1 commit into from

Conversation

imjalpreet
Copy link
Member

@imjalpreet imjalpreet commented Nov 9, 2024 •
edited by steveburnett
Loading

Description

Skip throwing the exception (External location must be a directory) when location doesn't exist yet

Motivation and Context

Fixes #23977

Impact

Users will now be able to create an external table even if the location does not exist yet and write to the table using Presto.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@imjalpreet
Fix prestodb#23977: Allow creating a table with non-existent external…
f54fe66 
… location

Skip throwing the exception (External location must be a directory) when location doesn't exist yet
@imjalpreet imjalpreet self-assigned this Nov 9, 2024
@imjalpreet imjalpreet requested a review from a team as a code owner November 9, 2024 16:28
pratyakshsharma
pratyakshsharma reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@pratyakshsharma pratyakshsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @imjalpreet. Just trying to understand if the path would be created at the time of writing data into external tables going forward in case path does not exist? Since we are not creating the path here.

@tdcmeehan tdcmeehan added the from:IBM PR from IBM label Nov 22, 2024
@prestodb-ci prestodb-ci requested review from a team, psnv03 and pramodsatya and removed request for a team November 22, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pratyakshsharma pratyakshsharma pratyakshsharma left review comments

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

@psnv03 psnv03 Awaiting requested review from psnv03 psnv03 was automatically assigned from prestodb/ibm-reviewers

@pramodsatya pramodsatya Awaiting requested review from pramodsatya pramodsatya was automatically assigned from prestodb/ibm-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@imjalpreet imjalpreet

Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue when creating an external table in Presto Hive Connector
3 participants
@imjalpreet @pratyakshsharma @tdcmeehan